Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssl: disallow reading/writing to unstarted SSL socket #469

Merged
merged 1 commit into from
Nov 1, 2021
Merged

ssl: disallow reading/writing to unstarted SSL socket #469

merged 1 commit into from
Nov 1, 2021

Commits on Oct 24, 2021

  1. ssl: disallow reading/writing to unstarted SSL socket 

    OpenSSL::SSL::SSLSocket allowed #read and #write to be called before an
SSL/TLS handshake is completed. They passed unencrypted data to the
underlying socket.

This behavior is very odd to have in this library. A verbose mode
warning "SSL session is not started yet" was emitted whenever this
happened. It also didn't behave well with OpenSSL::Buffering. Let's
just get rid of it.

Fixes: ruby#9
    @rhenium
    rhenium committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    bf78074 View commit details
    Browse the repository at this point in the history