Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hashed secure compare #280

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Add hashed secure compare #280

merged 2 commits into from
Oct 28, 2019

Commits on Oct 26, 2019

  1. Rename OpenSSL.secure_compare to fixed_length_secure_compare 

    In 1ade643 the Rails-like secure_compare naming
was adopted and in original pull request introducing this functionality debate
around timing of hash functions followed. This made me realize why Rails'
default of hashing the values to protect users from making mistakes is a good
idea.
    @bdewater
    bdewater committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    446b8e2 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2019

  1. Add OpenSSL.secure_compare with same semantics as Active Support >= 5.2 

    secure_compare is for user input, fixed_length_secure_compare for already processed data that is known to have the same length
    @bdewater
    bdewater committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    9a91192 View commit details
    Browse the repository at this point in the history