Support client certificates with TLS 1.3 #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable post-handshake authentication with OpenSSL 1.1.1 Fixes ruby#237
|
This looks pretty reasonable, do you mind rebasing on master and also pointing me at documentation that explains or shows that this function is being used in the right way? |
|
I read issue and curl implementation. I am happy with this PR. |
|
Will this be released with the next Ruby version? Because I understood that this gem here is packaged with ruby and is what's used e.g. when doing Faraday https requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable post-handshake authentication with OpenSSL 1.1.1
Fixes #237