Use grouping instead of generic_symbol #475
Merged
+393
−377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yui-knk
approved these changes
Oct 2, 2024
yui-knk
reviewed
Oct 2, 2024
| @@ -18,6 +18,13 @@ | |||
| %printer { | |||
| print_token(); | |||
| } tNUMBER tSTRING | |||
| %destructor { | |||
There was a problem hiding this comment.
Is this intentional change or forget to remove after debug?
There was a problem hiding this comment.
Intentionally change it. I noticed in spec/lrama/context_spec.rb that .flatten is needed in %printer. So I also added %destructor and %error-token. However, I am sure that they are not essential tests in this file, so you may want to check them with other tests. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.