Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: trivial refactoring #366

Merged
merged 7 commits into from
Feb 6, 2024
Merged

chore: trivial refactoring #366

merged 7 commits into from
Feb 6, 2024

Conversation

ydah
Copy link
Member

@ydah ydah commented Jan 31, 2024

No description provided.

@ydah ydah force-pushed the refactor branch 2 times, most recently from a03339e to 496d657 Compare January 31, 2024 14:05
@yui-knk
Copy link
Collaborator

yui-knk commented Feb 4, 2024

A lot of changes looks good. Two points I want to keep are:

  1. <<- style for "lib/lrama/output.rb" 786330f because they are embedded C codes then it's easy for me to understand what actually embedded by using <<-
  2. Previous codes of bc89c4e because currently I feel it's simple to modify or print something in if block when it's one line, this is just my preference.

@ydah
Copy link
Member Author

ydah commented Feb 5, 2024

Sorry for the delay, I changed it back to <<- for lib/lrama/output.rb. Also, I removed the bc89c4e change.

@yui-knk yui-knk merged commit 9585696 into ruby:master Feb 6, 2024
17 checks passed
@yui-knk
Copy link
Collaborator

yui-knk commented Feb 6, 2024

Thank you!

@ydah ydah deleted the refactor branch February 6, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants