JSON.dump: handle unenclosed hashes regression #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: ruby#553 We can never add keyword arguments to `dump` otherwise existing code using unenclosed hash will break.
|
👍 |
|
@byroot Now |
|
No it's not... but since it's a new feature it's less if a problem. I'll submit another PR soon. Thank you for letting me know |
eileencodes
added a commit
to rails/rails
that referenced
this pull request
Dec 1, 2023
Locks the json gem to 2.6.3 until there is a new release that includes ruby/json#554
|
If I may: #556 |
k0kubun
reviewed
Dec 1, 2023
| private | ||
|
|
||
| def merge_dump_options(opts, strict: NOT_SET) | ||
| opts[:strict] = strict if NOT_SET != strict |
There was a problem hiding this comment.
This can destructively modify JSON.dump_default_options. I addressed that in #556.
zzak
pushed a commit
to rails/rails
that referenced
this pull request
Dec 1, 2023
Locks the json gem to 2.6.3 until there is a new release that includes ruby/json#554
casperisfine
pushed a commit
to Shopify/rails
that referenced
this pull request
Dec 2, 2023
Don't use `json` 2.7.0 release that has a regression. Ref: ruby/json#554
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #553
We can never add keyword arguments to
dumpotherwise existing code using unenclosed hash will break.cc @hsbt