Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Skip TypeCompletion test in ruby ci (#748)" #755

Merged
merged 1 commit into from
Nov 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ jobs:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
- name: Run tests
run: WITH_TYPE_COMPLETION_TEST=1 bundle exec rake test
run: bundle exec rake test
- name: Run tests in isolation
run: WITH_TYPE_COMPLETION_TEST=1 bundle exec rake test_in_isolation
run: bundle exec rake test_in_isolation
vterm-yamatanooroti:
needs: ruby-versions
name: >-
Expand Down
1 change: 0 additions & 1 deletion test/irb/test_context.rb
Original file line number Diff line number Diff line change
Expand Up @@ -653,7 +653,6 @@ def test_lineno
end

def test_build_completor
pend 'set ENV["WITH_TYPE_COMPLETION_TEST"] to run this test' unless ENV['WITH_TYPE_COMPLETION_TEST']
verbose, $VERBOSE = $VERBOSE, nil
original_completor = IRB.conf[:COMPLETOR]
IRB.conf[:COMPLETOR] = :regexp
Expand Down
2 changes: 0 additions & 2 deletions test/irb/type_completion/test_scope.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# frozen_string_literal: true

return unless ENV['WITH_TYPE_COMPLETION_TEST']

return unless RUBY_VERSION >= '3.0.0'
return if RUBY_ENGINE == 'truffleruby' # needs endless method definition

Expand Down
2 changes: 0 additions & 2 deletions test/irb/type_completion/test_type_analyze.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# frozen_string_literal: true

return unless ENV['WITH_TYPE_COMPLETION_TEST']

# Run test only when Ruby >= 3.0 and %w[prism rbs] are available
return unless RUBY_VERSION >= '3.0.0'
return if RUBY_ENGINE == 'truffleruby' # needs endless method definition
Expand Down
2 changes: 0 additions & 2 deletions test/irb/type_completion/test_type_completor.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# frozen_string_literal: true

return unless ENV['WITH_TYPE_COMPLETION_TEST']

# Run test only when Ruby >= 3.0 and %w[prism rbs] are available
return unless RUBY_VERSION >= '3.0.0'
return if RUBY_ENGINE == 'truffleruby' # needs endless method definition
Expand Down
2 changes: 0 additions & 2 deletions test/irb/type_completion/test_types.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# frozen_string_literal: true

return unless ENV['WITH_TYPE_COMPLETION_TEST']

return unless RUBY_VERSION >= '3.0.0'
return if RUBY_ENGINE == 'truffleruby' # needs endless method definition

Expand Down