Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Combine into a shared matrix #27

Merged
merged 9 commits into from
Dec 26, 2021
Merged

CI: Combine into a shared matrix #27

merged 9 commits into from
Dec 26, 2021

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Oct 12, 2021

This PR combines the different Workflows into a single one.

I tricked around with it, but I am guessing the Rake tasks need a little bit of cajoling to get to run with Bundler.

That is why I opted out of the regularly-added Bundler cache.

>   | /opt/hostedtoolcache/Ruby/3.0.2/x64/lib/ruby/gems/3.0.0/gems/bundler-2.2.29/lib/bundler/runtime.rb:309:in `check_for_activated_spec!': You have already activated io-console 0.5.7, but your Gemfile requires io-console 0.5.9. Since io-console is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports io-console as a default gem. (Gem::LoadError)
@olleolleolle
Copy link
Contributor Author

@deivid-rodriguez Do you have a clue about the thing happening to fail the build here?

@olleolleolle olleolleolle changed the title CI: Combine into a shared matrix CI: Combine into a shared matrix (experimenting) Oct 12, 2021
@olleolleolle
Copy link
Contributor Author

Right, now we are at a stage where all the things are in the same Workflow, and green.

If we used Bundler.with_unbundled_env or the like, in the Rake tasks, we may get away with using the Bundler cache functionality.

@olleolleolle olleolleolle changed the title CI: Combine into a shared matrix (experimenting) CI: Combine into a shared matrix Oct 12, 2021
@deivid-rodriguez
Copy link

Sorry I couldn't help.

@nobu nobu merged commit ecc153e into master Dec 26, 2021
@nobu nobu deleted the ci-matrix branch December 26, 2021 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants