Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make verbose output go to stdout instead of stderr #49

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

jeremyevans
Copy link
Contributor

Verbose output is not error output, and should be sent to
stdout and not stderr.

Fixes Ruby bug 4436

Verbose output is not error output, and should be sent to
stdout and not stderr.

Fixes Ruby bug 4436
@deivid-rodriguez
Copy link
Contributor

What are the concerns here? It seems like a bug to me.

I don't think people should be relying on logging output being printed to stderr. If at all, I'm guessing they would want to rely on the opposite and be hit by this issue.

@deivid-rodriguez
Copy link
Contributor

Thanks! 🎉

@deivid-rodriguez
Copy link
Contributor

It was reverted in d98c687 :(

@nobu @hsbt Why not upgrading rake's tests to use the fixed fileutils? What's the upgrade path now? Shouldn't we at least correct rake's tests to not depend on this behaviour?

@hsbt
Copy link
Member

hsbt commented Sep 15, 2020

I have no idea to resolve this situation yet. We can merge this PR again when rake test support the behavior of fileutils bundled with Ruby 2.5 to 3.0.

@jeremyevans
Copy link
Contributor Author

I can work on a patch to rake that will work both with stderr or stdout.

@jeremyevans
Copy link
Contributor Author

I already fixed this in rake back in June: ruby/rake@bfdf462

Rake just needs to put out a 13.0.2 release with that fix.

@deivid-rodriguez
Copy link
Contributor

Maybe a good time to release a new rake version and reintroduce this? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants