Remove redundant raw detach test #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
changed the title
st0012
force-pushed
the
remove-unnecessary-raw-test
branch
3 times, most recently
from
3e4612f to
9fe6e67
Compare
The test's subject is the `disconnect` request with `restart: false, terminateDebuggee: <true|false>` arguments, which has been covered by the tests in `disconnect_dap_test.rb`. So this test case has become obsolete. Co-authored-by: Andy Waite <[email protected]>
st0012
force-pushed
the
remove-unnecessary-raw-test
branch
from
9fe6e67 to
6e8f4d1
Compare
|
Thank you for investigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test's subject is the
disconnectrequest withrestart: false, terminateDebuggee: <true|false>arguments, which has been covered by thetests in
disconnect_dap_test.rb. So this test case has become obsolete.Background
I was investigating the master build failure with @andyw8. And we later found that this test case isn't designed to catch that error and actually is redundant. So by removing it we can also fix part of the master build failure.
If having a test to capture the stacktrace difference of the test failure is preferred, I'll be happy to open another PR for it. But IMO, it'd be testing Ruby's behaviour instead of testing this gem.