Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suppress warnings about deprecated global variables #863

Merged
merged 1 commit into from
Dec 6, 2022
Merged

suppress warnings about deprecated global variables #863

merged 1 commit into from
Dec 6, 2022

Conversation

arika
Copy link
Contributor

@arika arika commented Dec 5, 2022

Description

rdbg --open may print deprecation warnings when global variables retrieved by DAP client.

sample code:

Warning[:deprecated] = true
p 1

sample output:

$ rdbg --open --sock-path=/tmp/rdbg.sock --command -- ruby test.rb
DEBUGGER: Debugger can attach via UNIX domain socket (/tmp/rdbg.sock)
DEBUGGER: wait for debugger connection...
DEBUGGER: Connected.
(eval):1: warning: variable $= is no longer effective
1
DEBUGGER: Disconnected.

ko1
ko1 reviewed Dec 5, 2022
View reviewed changes
lib/debug/thread_client.rb Outdated Show resolved Hide resolved
@arika
Copy link
Contributor Author

arika commented Dec 5, 2022 •
edited
Loading

I will rebase later 🙇‍♂️

@arika
Copy link
Contributor Author

arika commented Dec 5, 2022

I rebased, run test_all, and push -f.

@ko1 ko1 merged commit b4ec2d7 into ruby:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ko1 ko1 ko1 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arika @ko1