Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUBY_DEBUG_LAZY boot option #860

Merged
merged 1 commit into from
Dec 2, 2022
Merged

RUBY_DEBUG_LAZY boot option #860

merged 1 commit into from
Dec 2, 2022

Conversation

ko1
Copy link
Collaborator

@ko1 ko1 commented Dec 2, 2022

With RUBY_DEBUG_LAZY=1, require 'debug' doesn't start a session
but start when debugger method is called (or require 'debug/start'
is called).

This feature is experimental.
#797

With `RUBY_DEBUG_LAZY=1`, `require 'debug'` doesn't start a session
but start when `debugger` method is called (or `require 'debug/start'`
is called).

This feature is experimental.
#797
@st0012
Copy link
Member

st0012 commented Dec 2, 2022

Thank you for this PR, I'll test it today.

@ko1 ko1 merged commit 31cb9ee into master Dec 2, 2022
@ko1 ko1 deleted the lazy_mode branch December 2, 2022 13:09
@ko1
Copy link
Collaborator Author

ko1 commented Dec 2, 2022

Thank you.
If you have any trouble, please make an issue.

@st0012
Copy link
Member

st0012 commented Dec 2, 2022

I've tested it and the result looks promising 🎉 I'll make it the default in one of our major apps next week and see if any dev report issues.

FWIW, v1.7.0 itself is already a big improvement. 2 apps that used to break CI with debugger activated now works fine WITHOUT applying this feature 👍 Thanks for the work 🙏

A few other apps are still failing though (with reduced number of errors), so we still need this lazy-activation for the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants