CDP: do not override UI_ServerBase::readline
#812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, random failures such as `Timeout::Error` and `Errno::ECONNREFUSED` have been occurring. The reason for the error in CDP test is that UI_ServerBase::readline is overridden in CDP. continue is executed as a debug command because UI_CDP::readline returns continue if @q_msg is nil. See #8 for information on how to reproduce the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, random failures such as
Timeout::ErrorandErrno::ECONNREFUSEDhave been occurring. The reason for the error in CDP test is that UI_ServerBase::readline is overridden in CDP. continue is executed as a debug command because UI_CDP::readline returns continue if @q_msg is nil. See ono-max#8 for information on how to reproduce the error.