Fix bug that "trace line" does not work after stopping trace once

ruby · Mar 7, 2023 · bd9a3be · bd9a3be
1 parent 411d7e6
commit bd9a3be
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 1 deletion.
diff --git a/lib/debug/session.rb b/lib/debug/session.rb
@@ -1524,7 +1524,7 @@ def add_iseq_breakpoint iseq, **kw
     # tracers
 
     def add_tracer tracer
-      if @tracers.has_key? tracer.key
+      if @tracers[tracer.key]&.enabled?
         tracer.disable
         @ui.puts "Duplicated tracer: #{tracer}"
       else

diff --git a/lib/debug/tracer.rb b/lib/debug/tracer.rb
@@ -54,6 +54,10 @@ def disable
       @tracer.disable
     end
 
+    def enabled?
+      @tracer.enabled?
+    end
+
     def description
       nil
     end

diff --git a/test/console/trace_test.rb b/test/console/trace_test.rb
@@ -532,5 +532,31 @@ def test_tracer_prints_correct_method_receiving_messages
         end
       end
     end
+
+    class TraceOnAfterStoppingOnceTest < ConsoleTestCase
+      def program
+        <<~RUBY
+          1| a=1
+          2|
+          3| b=1
+          4|
+          5| c=1
+          6| p a
+        RUBY
+      end
+
+      def test_1656237686
+        debug_code(program) do
+          type 'trace line'
+          type 'trace off'
+          type 'trace line'
+          type 'b 5'
+          type 'c'
+          assert_line_num 5
+          assert_line_text(/DEBUGGER \(trace\/line\)/)
+          type 'kill!'
+        end
+      end
+    end
   end
 end