Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for test-bundled-gems at ruby/ruby repo #283

Merged
merged 7 commits into from
Jan 18, 2024

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Jan 17, 2024

There is no way to load bigdecimal extension in assert_in_out_err with make test-bundled-gems of ruby/ruby repository.

I added extension directory for that explicitly. I know this is ad-hoc solution. We should provide these paths to like assert_in_out_err assertions in ruby/ruby side.

@hsbt
Copy link
Member Author

hsbt commented Jan 17, 2024

https://github.com/ruby/bigdecimal/actions/runs/7552785831/job/20562319734?pr=283 is caused by io-console side at ruby/io-console#65.

I will release fixed version tomorrow.

@hsbt hsbt merged commit 3816e76 into master Jan 18, 2024
53 checks passed
@hsbt hsbt deleted the fix-test-bundled-gems-3-4 branch January 18, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant