Fix translate pluralization with nil in pluralization data #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fatkodima based on what I've seen on usage of That being said, if you fix the merge conflict here, we can flag the maintainers and see what they think. |
fatkodima
force-pushed
the
fix-t-pluralization-with-nil
branch
from
ff7bd4c
to
aaf06dd
Compare
|
@oniofchaos done. |
|
@radar another one for you 🎁 💝 see my comment above. |
* master: (131 commits) Use Ruby 2.7.1 Trigger actions on pull requests to master Bump Rake to v13 Bump rake to v13 Use flat_map instead of map.flatten in defaults Reduce memory usage in compute Reduce memory usage in Tag::Parents module Map in-place subtags Use flat_map instead of map.flatten in normalize_key Double-splat the arguments for I18n.translate Revert "Fix Ruby 2.7 keyword arguments related deprecation warning in Proc call" Misc readme updates Added double splat to resolve deprecation warning Switch to new GitHub issue template Update issue templates Bump to 1.8.2 Fix regression introduced by b7f69f7 Add pry to Gemfile Expand post-install message to clarify for new apps Revert "Revert "Chain fallback backends"" ...
|
This PR is failing the build. Please update it to pass. |
|
You're right. I think it is better to ignore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #303.
Looks like it is more logically correct to raise an error rather than return
translation missing:...in this case. wdyt?