-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic registration #2516
Open
ericproulx
wants to merge
17
commits into
ruby-grape:master
Choose a base branch
from
ericproulx:dynamic_registration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dynamic registration #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r.rb and validation_errors.rb
Add deregister module in spec
ContractScope validator has been moved to validations/validators and renamed properly
Fix rubocop
Refactor Grape::Validations::Types cache_key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings a common way to load parsers, formatters, validators and middleware versioners. With this change, it facilitates the customization through inheritance.
Parsers, formatters and error formatters
Parsers, formatters and error formatters had static constant named
DEFAULTS
that was acting as a lookup to translate a format (:json, :xml, etc ...) to an actual class. Instead of relying on this, it will now use a dynamic registryGrape::Util::Registry
that will be warmed up through inheritance like the validators (Seebase
classes) Thus,zeitwerk
, eager loads classes, so the registries are filled up when Grape is required.Versioners
I applied the same pattern for middleware versioners since its translating a symbol to an actual class.
Validators
For the validators, I've just replace the actual registry by
Grape::Util::Registry
and I removed theconst_get
part since all validators are eager loaded.Contract scope
I moved the contract scope validator to the
validators
folders and rename it toContractScopeValidator
to have a better short name thanvalidator
.Grape::Util::Registry
#2437 introduced a
length
validator and users that already have one with the same name might not be aware that its been overridden. Giving the situation, the registry will emit a warning if an entry has changed. This is true for all classes that are using the registry.DryTypeCoercer
I've refactored the part where its was calling
const_get
to use a static array.