DRY-up test workflow. #2423
Merged
DRY-up test workflow. #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of a CHANGELOG.md entry: * [#2423](https://github.com/ruby-grape/grape/pull/2423): Dry-up test workflow - [@dblock](https://github.com/dblock).Generated by 🚫 Danger |
dblock
force-pushed
the
simplify-workflow
branch
2 times, most recently
from
f9fbb8c to
5a26ceb
Compare
|
It adds more repetition, but on the plus side it's more transparent and explicit. One fewer step and variable as well. On the balance, probably an improvement. 🙂 |
ericproulx
requested changes
Apr 9, 2024
dblock
force-pushed
the
simplify-workflow
branch
from
5a26ceb to
cb699f1
Compare
dblock
force-pushed
the
simplify-workflow
branch
from
cb699f1 to
752b6dd
Compare
ericproulx
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dgutov do you think this is better? It gets rid of the indirections by removing the concept of "integration", and making both gemfile used and specs declarative.