Tweak Rubocop rules; add more exceptions to the main config #2421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dblock In reply to your comment in #2419:
What I ended up doing is calling
bundle exec rubocop --regenerate-todo
. But I think that's a problem for potential contributors - to understand which rules should be followed, and which can/should just be put into the todo.CONTRIBUTING says this, after all:
So here's an update to the default config which addresses the 3 main cops which gave me trouble.
Ultimately, it seems like you might prefer to just disable all three instead (and maybe more). But this is a more conservative change.