Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mime-types dependency in specs #2406

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Remove mime-types dependency in specs #2406

merged 2 commits into from
Jan 5, 2024

Conversation

ericproulx
Copy link
Contributor

This PR removes mime-types has a dependency when testing. It was only used in 3 specs.

@ericproulx ericproulx requested a review from dblock January 5, 2024 21:48
@ericproulx ericproulx marked this pull request as ready for review January 5, 2024 21:48
@grape-bot
Copy link

grape-bot commented Jan 5, 2024 •
edited
Loading

1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 Danger

@dblock dblock merged commit 10944de into ruby-grape:master Jan 5, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericproulx @grape-bot @dblock