Optimize AttributeTranslator #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define setter methods in AttributeTranslator Combine default route attributes + desc attributes Refactor Pattern Remove description in settings
Remove delete options
ericproulx
changed the title
|
This is better! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #2375, I've spent some time understanding the
Grape::Router::AttributeTranslatoracross the gem. I knew already what it did but I didn't know where it was used exactly. This PR is an effort to optimize the usage of the AttributeTranslator but also some refactoring across theGrape::Routerclasses.Changes:
Grape::Router::GreedyRouteto encapsulateGrape::Router::AttributeTranslatorin the greedy match process.Grape::Router::AttributeTranslatordefines more methods to not rely onmethod_missinginternally.Grape::Router::PatternandGrape::Router::Routehave been refactored.