Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce gem size by removing test_files (spec) #2360

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

ericproulx
Copy link
Contributor

It occurred to me while installing the gem that spec files are included. It represents half the size of the gem. Nowadays, most gem does not include them and I think Grape should do the same.

Refactor files
@grape-bot
Copy link

grape-bot commented Oct 21, 2023

1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 Danger

@ericproulx ericproulx requested a review from dblock October 21, 2023 14:11
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd think that it would know not to include test_files?

@dblock dblock merged commit 51b081c into ruby-grape:master Oct 21, 2023
31 checks passed
@ericproulx
Copy link
Contributor Author

You'd think that it would know not to include test_files?

I know right! It's been deprecated for quite a long time now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants