Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use COVERALLS_PARALLEL as recommended to combine coverage reports. #2265

Closed
wants to merge 1 commit into from

Conversation

dblock
Copy link
Member

@dblock dblock commented Jun 14, 2022

Let's see if this does anything? https://docs.coveralls.io/parallel-build-webhook

@dblock dblock marked this pull request as draft June 14, 2022 22:26
@grape-bot
Copy link

1 Warning
⚠️ Unless you're refactoring existing code or improving documentation, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#2265](https://github.com/ruby-grape/grape/pull/2265): Use coveralls_parallel as recommended to combine coverage reports - [@dblock](https://github.com/dblock).

Generated by 🚫 Danger

@dblock dblock marked this pull request as ready for review June 14, 2022 22:28
@duffn
Copy link
Member

duffn commented Jun 14, 2022

If this doesn't work, it could be worthwhile to explore using the Coveralls GitHub Action (https://github.com/marketplace/actions/coveralls-github-action) instead. Both Coveralls and the coveralls-reborn package itself even recommend it https://github.com/tagliala/coveralls-ruby-reborn#github-actions

@dblock
Copy link
Member Author

dblock commented Jun 14, 2022

@duffn I think this doesn't work and we should get closer to https://github.com/tagliala/coveralls-ruby-reborn#github-actions (just minus Rails). The GHA app is authorized, so it will also work on pull requests (no secret key required).

@duffn
Copy link
Member

duffn commented Jun 15, 2022

#2266

@duffn
Copy link
Member

duffn commented Jul 18, 2022

This can be closed. Coveralls was fixed in #2266

@dblock dblock closed this Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants