Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Coveralls code coverage #2264

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Conversation

duffn
Copy link
Member

@duffn duffn commented Jun 13, 2022

Currently

Randomized with seed 1113
[Coveralls] Submitting to https://coveralls.io/api/v1
[Coveralls] Couldn't find a repository matching this job.
Coverage is at 98.94%.
Coverage report sent to Coveralls.

On my fork after adding the Coveralls token

Randomized with seed 57600
[Coveralls] Submitting to https://coveralls.io/api/v1
[Coveralls] Job ##8.1
[Coveralls] https://coveralls.io/jobs/101153293
Coverage is at 98.94%.
Coverage report sent to Coveralls.

Closes #2061.

@dblock
Copy link
Member

dblock commented Jun 14, 2022

I added COVERALLS_REPO_TOKEN here.

@dblock dblock merged commit 7ee07d1 into ruby-grape:master Jun 14, 2022
@dblock
Copy link
Member

dblock commented Jun 14, 2022

Merged. Could you please check that master got coverage successfully now?

@dblock
Copy link
Member

dblock commented Jun 14, 2022

https://coveralls.io/jobs/101222049

@duffn duffn deleted the duffn/fix-coveralls-token branch June 14, 2022 18:58
@dblock
Copy link
Member

dblock commented Jun 14, 2022

I'm confused by what I'm seeing in https://coveralls.io/github/ruby-grape/grape. The top build now is https://coveralls.io/builds/50022726, so it looks like it doesn't add up the various tests into coverage but overwrites one with the other? The overall badge is still 99% it seems, too. So, what's our actual code coverage in tests?

@dblock
Copy link
Member

dblock commented Jun 14, 2022

@duffn see lemurheavy/coveralls-public#1505, maybe you'll find a solution to this?

@duffn
Copy link
Member Author

duffn commented Jun 14, 2022

I’m not intimately familiar with Coveralls, but I’ll take a look at what’s going on here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix code coverage
2 participants