Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ruby 2.7 keyword deprecations #2091

Merged
merged 7 commits into from
Aug 10, 2020
Merged

Fix Ruby 2.7 keyword deprecations #2091

merged 7 commits into from
Aug 10, 2020

Conversation

dim
Copy link
Contributor

@dim dim commented Jul 15, 2020

Another attempt to address #2090 properly

@dblock
Copy link
Member

dblock commented Jul 15, 2020

Not sure what's up with CI, force push?

@dim dim force-pushed the fix/ruby-2.7-keyword-deprecations branch from a60eb1f to 89df3ec Compare July 16, 2020 07:57
dblock
dblock requested changes Jul 16, 2020
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also love it if 2.7+ build failed if there were any warnings so we can make sure we actually fixed it for real.

lib/grape/middleware/stack.rb Outdated Show resolved Hide resolved
@dim dim force-pushed the fix/ruby-2.7-keyword-deprecations branch from 86c386f to 67013a3 Compare August 10, 2020 10:59
@dim dim requested a review from dblock August 10, 2020 10:59
dblock
dblock requested changes Aug 10, 2020
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some legit build failures, would merge on 🍏.

lib/grape/middleware/stack.rb Outdated Show resolved Hide resolved
lib/grape/middleware/stack.rb Outdated Show resolved Hide resolved
@dim dim requested a review from dblock August 10, 2020 13:51
@dblock dblock merged commit 6deb8f4 into ruby-grape:master Aug 10, 2020
@dblock
Copy link
Member

dblock commented Aug 10, 2020

Much thanks.

@dblock dblock mentioned this pull request Aug 10, 2020
Closed
@dmke dmke mentioned this pull request Dec 16, 2020
Closed
This was referenced Mar 8, 2021
Closed
Closed
Closed
Closed
Open
@neocoin neocoin mentioned this pull request Apr 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock Awaiting requested review from dblock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dim @dblock