Improve UPGRADING.md instructions for custom types #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Provide an example for taking an existing type and porting it to the dry-types. This would have saved me some time. * Removed examples of using `Virtus.model`. It seems confusing to support dry-types and Virtus at the same time. Closes ruby-grape#2012
Here's an example of a CHANGELOG.md entry: * [#2029](https://github.com/ruby-grape/grape/pull/2029): Improve upgrading.md instructions for custom types - [@stanhu](https://github.com/stanhu).Generated by 🚫 danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide an example for taking an existing type and porting it to
the dry-types. This would have saved me some time.
Removed examples of using
Virtus.model. It seems confusing tosupport dry-types and Virtus at the same time.
Closes #2012