Deep merge params for definition

[jdmurphy]

I found that when using body params in PUT and POST, a nested entity in the params that has a description set at the entity level will not have that description in the OpenAPI spec output. For example given:

params do
  requires :spline, description: 'It is a spline', documentation: {param_type: 'body'}, type: Hash do
    requires :x, type: Numeric
    requires :y, type: Numeric
  end
  optional :reticulated, type: Boolean, default: true, desc: 'True if the spline is reticulated.'
end

a definition will be created (notice that the spline hash under properties has no description):

"postSplines":{  
   "type":"object",
   "properties":{  
      "spline":{  
         "type":"object",
         "properties":{  
            "x":{  
               "type":"integer",
               "format":"int64"
            },
            "y":{  
               "type":"integer",
               "format":"int64"
            }
         },
         "required":[  
            "x",
            "y"
         ]
      },
      "reticulated":{  
         "type":"boolean",
         "description":"True if the spline is reticulated."
      }
   },
   "required":[  
      "spline"
   ],
   "description":"Create a spline."
 }

With my fix a deep merge occurs which maintains elements on the parent object when merging a nested element: (and the description of "It is a spline" is kept)

"postSplines":{  
   "type":"object",
   "properties":{  
      "spline":{  
         "type":"object",
         "description":"It is a spline",
         "properties":{  
            "x":{  
               "type":"integer",
               "format":"int64"
            },
            "y":{  
               "type":"integer",
               "format":"int64"
            }
         },
         "required":[  
            "x",
            "y"
         ]
      },
      "reticulated":{  
         "type":"boolean",
         "description":"True if the spline is reticulated."
      }
   },
   "required":[  
      "spline"
   ],
   "description":"Create a spline."
}

while looking into this I noticed that the recursive_call function was using the property parameter as a key without regard to its format which could lead to having string and symbols mixed together specifically when nested params are being evaluated (the nested param would be the string whereas every other element would be a symbol), so I added a call to .to_sym to ensure use of symbols throughout since we are using Hash and not HashWithIndifferentAccess.

[coveralls]

Coverage increased (+0.0006%) to 99.529% when pulling 7f86525 on jdmurphy:deep_merge_params into c25fe68 on ruby-grape:master.

[LeFnord]

thanks @jdmurphy