Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for deprecated field #670

Merged
merged 5 commits into from
Mar 17, 2018
Merged

Add support for deprecated field #670

merged 5 commits into from
Mar 17, 2018

Conversation

ioanatia
Copy link
Contributor

@coveralls
Copy link

coveralls commented Mar 16, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 97.248% when pulling cfb797e on ioanatia:ioanatia_add_deprecated_option into 7005eff on ruby-grape:master.

LeFnord
LeFnord approved these changes Mar 17, 2018
View reviewed changes
Copy link
Member

@LeFnord LeFnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will fix the rubocop issues in another PR

lib/grape-swagger/endpoint.rb Outdated
@@ -4,6 +4,7 @@
require 'active_support/core_ext/string/inflections.rb'

module Grape
# rubocop:disable Metrics/ClassLength
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't add it here, specify it in the .rubocop-todo.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, and I will fix the other two rubocop issues that causes the CI to fail.

@LeFnord
Copy link
Member

LeFnord commented Mar 17, 2018

thanks @ioanatia …

@ioanatia ioanatia force-pushed the ioanatia_add_deprecated_option branch from 89a002d to bd57ca8 Compare March 17, 2018 09:40
@LeFnord
Copy link
Member

LeFnord commented Mar 17, 2018

thanks again @ioanatia

@LeFnord LeFnord merged commit 0e69fed into ruby-grape:master Mar 17, 2018
@ioanatia ioanatia deleted the ioanatia_add_deprecated_option branch March 17, 2018 11:48
@ioanatia
Copy link
Contributor Author

thanks for reviewing this so quickly 😸

@ioanatia ioanatia mentioned this pull request Apr 1, 2018
Merged
LeFnord pushed a commit to LeFnord/grape-swagger that referenced this pull request Feb 9, 2019
@ioanatia @LeFnord
Add support for deprecated field (ruby-grape#670)
148aba3 
* Add deprecated property

* Add specs

* Fix linting issues

* Add entry in CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeFnord LeFnord LeFnord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ioanatia @coveralls @LeFnord