Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support extensions on the root object #608

Merged
merged 6 commits into from
May 10, 2017
Merged

support extensions on the root object #608

merged 6 commits into from
May 10, 2017

Conversation

thogg4
Copy link
Contributor

@thogg4 thogg4 commented May 8, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 100.0% when pulling f5cb5a1 on itransact:add-root-extensions into 3493e3c on ruby-grape:master.

LeFnord
LeFnord requested changes May 10, 2017
View reviewed changes
Copy link
Member

@LeFnord LeFnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks @thogg4 … it seems this PR makes the extension stuff more complete, but I missing a spec, not from the testing perspective, more from the documentation perspective

@thogg4
Copy link
Contributor Author

thogg4 commented May 10, 2017

@LeFnord great point. how is that?

LeFnord
LeFnord approved these changes May 10, 2017
View reviewed changes
Copy link
Member

@LeFnord LeFnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 😄

@LeFnord
Copy link
Member

LeFnord commented May 10, 2017

@thogg4 please fix the rubocop stuff and update the PR, so that it can be mörged 😄

@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 100.0% when pulling abd8c09 on itransact:add-root-extensions into b33ff7c on ruby-grape:master.

@LeFnord LeFnord merged commit c1d6bb0 into ruby-grape:master May 10, 2017
LeFnord pushed a commit to LeFnord/grape-swagger that referenced this pull request Feb 9, 2019
@thogg4 @LeFnord
support extensions on the root object (ruby-grape#608)
7408607 
* support extensions on the root object
* remove puts statement
* add spec for documentation
* tweaks for rubocop
* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeFnord LeFnord LeFnord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thogg4 @coveralls @LeFnord