Allow extension keys in Info Object #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeFnord
requested changes
Mar 1, 2017
There was a problem hiding this comment.
thanks @mattyr … but
- make rubocop happy → run
bundle exec raketo see the failures - missing changelog entry
- please add a entry to extension section in the README
- make rubocop happy - add changelog entry - add entry to extension section in the README
|
made the requested changes -- also made the extension format conform better with existing extensions ( quick question re: rubocop: i was getting a ton of errors so i thought that was ignored. looks like 99% are "Missing frozen string literal comment". I disabled that using .rubocop.yml file and just addressed those issues specific to these changes. Would you like a PR that either:
|
|
@mattyr … its a bit curious that this cop pops up, cause it is running some weeks, but prefer not to mix up your PR with a maintainance PR, and yeah here is it green |
LeFnord
pushed a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
* Allow extension keys in Info Object, per http://swagger.io/specification/#infoObject * address comments - make rubocop happy - add changelog entry - add entry to extension section in the README * fix changelog entry * another changelog fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per http://swagger.io/specification/#infoObject