Rename failures to failure in README #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking at the [specs in this project](https://github.com/ruby-grape/grape-swagger/blob/master/spec/swagger_v2/api_swagger_v2_detail_spec.rb#L35) and tne [REAME for ruby-grape/grape](https://github.com/ruby-grape/grape/blob/master/README.md#describing-methods), this argument should be 'failure' and not 'failures'.
justincampbell
force-pushed
the
rename-failures-failure
branch
from
03a5660 to
5001a64
Compare
kzaitsev
reviewed
Jan 4, 2017
| @@ -9,6 +9,8 @@ | |||
|
|
|||
| #### Fixes | |||
|
|
|||
| * [#561](https://github.com/ruby-grape/grape-swagger/pull/561): Rename failures to failure in readme - [@justincampbell](https://github.com/justincampbell). | |||
There was a problem hiding this comment.
You no need to do this, if you just change README.md
|
@Bugagazavr … it is ok for me -> it is a contribution 😉 and … want to have it in the master, to cut a new release |
LeFnord
pushed a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the specs in this project and tne REAME for ruby-grape/grape, this argument should be 'failure' and not 'failures'.