Use entity_name event if type come from a string #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeFnord
requested changes
Dec 6, 2016
| @@ -6,6 +6,12 @@ | |||
|
|
|||
| #### Fixes | |||
|
|
|||
| * [#547](https://github.com/ruby-grape/grape-swagger/pull/547): Use entity_name event if type come from a string - [@frodrigo](https://github.com/frodrigo). | |||
|
|
|||
| ### 0.25.2 (November 30, 2016) | |||
There was a problem hiding this comment.
please remove L#11-13 → duplicated
frodrigo
force-pushed
the
entity_name_from_string
branch
from
ed7cd22 to
cb02a5c
Compare
LeFnord
reviewed
Dec 6, 2016
| @@ -7,6 +7,7 @@ | |||
| #### Fixes | |||
|
|
|||
| * [#546](https://github.com/ruby-grape/grape-swagger/pull/546): Move development dependencies to Gemfile - [@olleolleolle](https://github.com/olleolleolle). | |||
| * [#547](https://github.com/ruby-grape/grape-swagger/pull/547): Use entity_name event if type come from a string - [@frodrigo](https://github.com/frodrigo). | |||
|
|
|||
There was a problem hiding this comment.
think you have to add: * Your contribution here. in line 11
There was a problem hiding this comment.
The problem with the lines is that they have a period before the - towards the end.
There was a problem hiding this comment.
ok @dblock … think now it would be nice to know how it should looks like …
sorry, but yhe syntax of the changelog hasn't my first priority 😉
|
@frodrigo … thanks, please can you make rubocop happy, run it local with |
LeFnord
approved these changes
Dec 8, 2016
|
yeah … happy to mörge |
LeFnord
pushed a commit
to LeFnord/grape-swagger
that referenced
this pull request
Dec 18, 2016
* Use entity_name event if type come from a string * Fix CHANGELOG.md format * Make rubocup happy
LeFnord
pushed a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
* Use entity_name event if type come from a string * Fix CHANGELOG.md format * Make rubocup happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.