-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development deps in Gemfile #546
Development deps in Gemfile #546
Conversation
Generated by 🚫 danger |
- move development dependencies to Gemfile (where there's platforms annotation support and ruby version identification) - update the Bundler version to latest, in Travis build step before_install, so that the smarts keep working - made Gemfile Rubocop-compliant
Hello, thanks, any reasons why we need this? |
@Bugagazavr Oh, you're welcome. The good part is that this uses the Bundler DSL to match and select versions and platforms (which it already does, partially). Now, by adding the Conditionals like this: if RUBY_VERSION < '2.2.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @olleolleolle for the improvement
@Bugagazavr … I'm fine with it
@@ -6,8 +6,7 @@ | |||
|
|||
#### Fixes | |||
|
|||
* Your contribution here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please can you re-add it above your entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, my fault, meant after
@@ -1,6 +1,8 @@ | |||
language: ruby | |||
|
|||
sudo: false | |||
before_install: | |||
- gem install bundler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@olleolleolle sorry … let it us it was in your first commit, I will have an eye on |
@LeFnord If it pleases you, I can squash the commits to a single one. |
Thanks again, will do it later, when I am on my machine |
* This PR moves the development dependencies to the Gemfile. - move development dependencies to Gemfile (where there's platforms annotation support and ruby version identification) - update the Bundler version to latest, in Travis build step before_install, so that the smarts keep working - made Gemfile Rubocop-compliant * CHANGELOG.md - add back missing line * Move line in CHANGELOG.md * CHANGELOG.md danger warning
* This PR moves the development dependencies to the Gemfile. - move development dependencies to Gemfile (where there's platforms annotation support and ruby version identification) - update the Bundler version to latest, in Travis build step before_install, so that the smarts keep working - made Gemfile Rubocop-compliant * CHANGELOG.md - add back missing line * Move line in CHANGELOG.md * CHANGELOG.md danger warning
This PR moves the development dependencies to the Gemfile.
platforms
annotation support andruby
version identification - upcoming versions of Bundler will not need this last annotation)before_install
, so that the smarts keep working