Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use route tags for global tag set #524

Merged
merged 2 commits into from
Oct 23, 2016
Merged

Conversation

LeFnord
Copy link
Member

@LeFnord LeFnord commented Oct 23, 2016

No description provided.

@@ -2,9 +2,10 @@

#### Features

* [#524](https://github.com/ruby-grape/grape-swagger/pull/524): Use route tags for global tag set - [@LeFnord](https://github.com/LeFnord).
* [#523](https://github.com/ruby-grape/grape-swagger/pull/523): Allow specifying custom tags at the route level. - [@jordanfbrown](https://github.com/jordanfbrown).
Copy link
Member

@dblock dblock Oct 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra period here not flagged by Danger.

@dblock
Copy link
Member

dblock commented Oct 23, 2016

You probably want to call this out in UPGRADING.

- adds changelog entry
- adds note in UPGRADING
@LeFnord LeFnord merged commit 7d405ff into ruby-grape:master Oct 23, 2016
LeFnord added a commit to LeFnord/grape-swagger that referenced this pull request Feb 9, 2019
* minor adoptions on README

* build global tag set from route tags
- adds changelog entry
- adds note in UPGRADING
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants