corrects exposing of inline definitions #503
Conversation
| @@ -288,7 +288,8 @@ def expose_params_from_model(model) | |||
| end | |||
|
|
|||
| def model_name(name) | |||
| name.respond_to?(:name) ? name.name.demodulize.camelize : name.split('::').last | |||
| name = name.to_s.split('::')[0..-2].join('::').constantize if name.to_s.end_with?('Entity', 'Entities') | |||
There was a problem hiding this comment.
Why we can't just drop all '::', and show model name as is?
There was a problem hiding this comment.
good point … I did it, cause the name could be very long, see the spec, without it the name it would be: TestDefinitionClass1, it would have all namespaces
There was a problem hiding this comment.
@Bugagazavr … what is your meaning?
There was a problem hiding this comment.
i think we can trim symbols if maximum defenition length is reached
There was a problem hiding this comment.
name.to_s.split('').reverse.take(255).reverse.join
There was a problem hiding this comment.
also we can add respond_to?(:entity_name) to customize name manually
There was a problem hiding this comment.
where would it it be set?
There was a problem hiding this comment.
i think this should be placed in model_name method
if name.respond_to?(:entity_name)
name.entity_name
else
name.to_s.gsub('::', '').split('').reverse.take(255).reverse.join
endThere was a problem hiding this comment.
yeap, but where in the entity/API definition would it be set?
There was a problem hiding this comment.
this should be a class method
| length < 42 | ||
| end.reverse.join | ||
| else | ||
| name.name.demodulize.camelize |
There was a problem hiding this comment.
I let it, cause without it, it would be a breaking change
- adds changelog entry - adds option to set definition name
- adds changelog entry - adds option to set definition name
|
I guess this is a late comment, but why there is 2 different code blocks for parsing model name?
Second question is what is the magic logic of dropping |
|
@serggl … thanks for spotting on it … it seems you have the knowledge to refactore it out, |
|
@LeFnord sure. On the way |
- adds changelog entry - adds option to set definition name
solves: