Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regex for Array and Multi Type in doc_methods #479

Merged
merged 1 commit into from
Jul 26, 2016
Merged

Fix regex for Array and Multi Type in doc_methods #479

merged 1 commit into from
Jul 26, 2016

Conversation

frodrigo
Copy link
Contributor

Parsing of "[APoint]" should return "APoint"

With current regex it fails:

irb(main):001:0> "[APoint]".gsub(/[(\A\[)(\s+)(\]\z)]/, '')
=> "Point"

@LeFnord
Copy link
Member

LeFnord commented Jul 25, 2016 •
edited
Loading

@frodrigo … thanks, but missing spec and changelog entry

@frodrigo
Copy link
Contributor Author

Updated

@LeFnord
Copy link
Member

LeFnord commented Jul 26, 2016

👍

@LeFnord LeFnord merged commit 43674b7 into ruby-grape:master Jul 26, 2016
LeFnord pushed a commit to LeFnord/grape-swagger that referenced this pull request Feb 9, 2019
@frodrigo @LeFnord
Fix regex for Array and Multi Type in doc_methods (ruby-grape#479)
dc2e25b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frodrigo @LeFnord