refoctors building definitions for body params #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| subject.instance_variable_set(:@definitions, definitions) | ||
| subject.find_definition_and_params(found_path[:post], :post) | ||
| expect(definitions.keys).to include 'InBody' | ||
| expect(definitions['postRequestInBody'].keys).to_not include :description |
There was a problem hiding this comment.
Wouldn't this case be lost?
There was a problem hiding this comment.
sorry … first comment was wrong and not related,
no it is always there, see: https://github.com/ruby-grape/grape-swagger/pull/467/files#diff-0a42864b10ca75eb0af2c0fc45139eb0R25
There was a problem hiding this comment.
but yeah should adding a spec to proof it, thanks
There was a problem hiding this comment.
Yep, I remember it from here https://github.com/ruby-grape/grape-swagger/pull/450/files :)
There was a problem hiding this comment.
yeap … re-added it, thanks 😄
LeFnord
force-pushed
the
master
branch
4 times, most recently
from
8bd6f23 to
4f5c54d
Compare
LeFnord
force-pushed
the
master
branch
2 times, most recently
from
2eb2d4e to
66bf885
Compare
- adds base spec - adds changelog entry
LeFnord
added a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
- adds base spec - adds changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.