Update UPGRADING.md #462
Closed
Update UPGRADING.md #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated upgrade guide from a change in commit ruby-grape@99c3d82 Not sure which version this falls under, added under >= 0.21.0
|
|
||
| ``` ruby | ||
| add_swagger_documentation \ | ||
| version: 'v1' |
There was a problem hiding this comment.
did you tried it? think this isn't possible anymore here, cause the API version should be specified in grape,
and not by grape-swagger, to be consistent and to have one place for it, here one could only add doc_version
There was a problem hiding this comment.
This is what i'm currently using in my project and if that's the case it looks like it forwards it on.
There was a problem hiding this comment.
Can overwrite the API version sets by grape?
If yes, please write a spec to document it → 👍
|
@BaneOfSerenity Maybe write a spec for this so we know for sure? Thanks. |
|
updated UPGRADE.me, inclusive spec could be found here #489 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated upgrade guide from a change in commit 99c3d82
Not sure which version this falls under, added under >= 0.21.0
Referenced in Issue #403