Include documented Hashes #453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized that I don't actually test for the functionality that I claim, so I will close this for right now. I unfortunately won't have access to update the tests for a couple of days, but I will add what's needed. As a brief summary, this PR specifically affects Hashes and Arrays in JSON bodies, which I failed to cover. I will reopen a new PR when I get the work straightened out. |
|
@aschuster3 … 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is opened to address Issue #445
Because of the way the logic is stated, raw Hashes can never be included. After digging through, I found that the reason this
unlessexists in the first place is because Hashes and Arrays are replaced with their object references (e.g."address"=>{"$ref"=>"#/definitions/someDefinition"}is preferred over"address"=>{"type"=>"object"}).