fixes grape to 0.14.0 #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeFnord
force-pushed
the
fix_dependencies
branch
2 times, most recently
from
92dff1d to
09925dc
Compare
LeFnord
force-pushed
the
fix_dependencies
branch
from
09925dc to
931cb9e
Compare
LeFnord
force-pushed
the
fix_dependencies
branch
from
931cb9e to
7839d9a
Compare
| gem 'grape', github: 'ruby-grape/grape' | ||
| else | ||
| gem 'grape', version | ||
| end |
There was a problem hiding this comment.
Removing this caused Travis to not build/test with different versions!
https://github.com/ruby-grape/grape-swagger/blob/master/.travis.yml
There was a problem hiding this comment.
mmh, then I should readd it …
There was a problem hiding this comment.
I also think we should not spend too much time supporting previous releases of things with newer versions, I suggest moving onward and enabling 0.16.x + whatever new stuff over older things.
There was a problem hiding this comment.
yeap, I totally agree with you …
but we should support grape 0.14.0 for a while, as I said, support for > 0.16.1 is on the road,
but we should give all a while to test actual grape-swagger version and improve it
LeFnord
added a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
fixes grape to 0.14.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing of grape-entity is not needed, tested it with: 0.4.8, 0.5.0 and 0.5.1 runs green always