adding entity property description when documentation desc option is present #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elciok
force-pushed
the
entity_field_descriptions
branch
from
b720d01 to
dbc887a
Compare
| @@ -35,6 +35,10 @@ | |||
|
|
|||
| [#353](https://github.com/ruby-grape/grape-swagger/pull/353) resolves issue #352 | |||
|
|
|||
| [](https://github.com/ruby-grape/grape-swagger/pull/) | |||
|
👍 thanks for it … |
elciok
force-pushed
the
entity_field_descriptions
branch
from
dbc887a to
175f3ee
Compare
LeFnord
added a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
adding entity property description when documentation desc option is present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The swagger_doc json generated contains entity definitions, with property declarations, but if you set a "desc" option like this:
expose :name, documentation: {type: "String", desc: "Name of object"}
This gets ignored by grape-swagger. I've changed this.