Patch to handle Array Declaration #237 #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,6 +47,12 @@ def parse_params(params, path, method) | |||
| 'double' | |||
| when 'Symbol' | |||
| 'string' | |||
| when /^\[(.*)\]$/ | |||
There was a problem hiding this comment.
Maybe use a named field here, like type. That avoids having a last_match[1] and is probably clearer.
|
If it's OK I can squash them. |
| when /^\[(?<type>.*)\]$/ | ||
| items[:type] = Regexp.last_match[:type].downcase | ||
| if PRIMITIVE_MAPPINGS.key?(items[:type]) | ||
| items[:type], items[:format] = PRIMITIVE_MAPPINGS[items[:type]] |
There was a problem hiding this comment.
I re-read this and find it a bit strange (or at least looks like a side-effect) that we're assigning items[] inside the case statement. Feels like this logic belongs below where we deal with items? I am not sure though, what do you think?
There was a problem hiding this comment.
Later we deal with parsed_params[:type], not items[:type], items just affected into parsed_params[:items].
|
Please squash and update CHANGELOG. Thanks. |
|
Squashed + changelog done |
dblock
added a commit
that referenced
this pull request
Jul 3, 2015
Patch to handle Array Declaration #237
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch to handle Array Declaration #237