Empty field for group parameters' name with type hash or Array

[salimane]

Take the following example:

params do
  optional :preferences, type: Array do
    requires :key
    requires :value
  end

  requires :name, type: Hash do
    requires :first_name
    requires :last_name
  end
end

In swagger-ui, there would be an empty text field for preferences and name. Is this suppoed to be this way ? Tested using the github version of grape and grape-swagger.

Thanks

[klausmeyer]

👍 had the same problem yesterday. It only occurs when I'm using grape master from github. On the official gem version 0.6.1 everything is fine.

[jhonathas]

On last version no worker?

[davetapley]

Same here 👋

This?

[klausmeyer]

Yes this is the problem I had.

[DavidValin]

I'm using the gem now to build my api and I see the same. Using grape-swagger (0.7.2) and grape-swagger-ui (0.0.4) and grape (0.7.0) :-(

[dblock]

Can someone please retest this against Grape 0.8.0 and maybe add specs around the issue here?

[davetapley]

@dblock coming right up.

[davetapley]

I've tracked this back to a change in grape between 0.6.0 and 0.8.0.
Awaiting to see if it's a regression there, or an expected change in behavior, see here.

[davetapley]

Okay, I've got a good conversation going with @dblock on that thread, where we've established that it was a regression (at least in the sense that the behavior change isn't fully understood / documented).

We'll figure it out there.

[syntaxTerr0r]

Hi there ! Any news on this ?

[dblock]

See https://github.com/tim-vandecasteele/grape-swagger/pull/117.

[davetapley]

Uh oh, since #47 got fixed (specifically since 04566fc went in), this is even more hilariously wrong.

To demonstrate it, I extended the test API with the relevant part of the specs, and ran it through http://petstore.swagger.wordnik.com/ to demonstrate:

Note that the 'empty field' is now a file selector 😆
I'd like to suggest that the fault lays with the implementation of the #47 fix, so I'll bring it up there too.

[dblock]

@dukedave Indeed. Care to PR some specs to start?

[davetapley]

@dblock okay, so 791943c demonstrates the problem shown in the image above.

Since the new file selector problem is only visible as a result of this issue, I just fixed this issue solely in 47168a4. For reference the spec to cover this fix went in on c18719f.

It's not the prettiest solution, but I don't see that grape is going to stop sending us these 'parent of a nested param' params any time soon (since it doesn't break anything in grape).

[dblock]

Fixed in tim-vandecasteele@15604b0.

[nono]

It's not really fixed. It doesn't work for the first example:

  optional :preferences, type: Array do
    requires :key
    requires :value
  end

Swagger-ui uses this to generate preferences[key]=foo&preferences[value]=bar, as if preferences was an hash and not array.

[dblock]

@nono, can you please reopen a bug, hopefully with a failing spec? Thanks.