Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.0 support and drop 2.4/2.5 support #257

Merged
merged 2 commits into from
May 5, 2021

Conversation

tnir
Copy link
Collaborator

@tnir tnir commented May 1, 2021

Add Ruby 3.0 support and drop 2.4/2.5 support.

@tnir tnir force-pushed the ruby30 branch 2 times, most recently from 068614c to f7c7a6a Compare May 1, 2021 17:37
@gingermusketeer gingermusketeer force-pushed the ruby30 branch 2 times, most recently from 3c1eb36 to 05cd4ef Compare May 5, 2021 19:35
Why: Looks to be needed by simplecov-cobertura. Trying to keep rufo dependency free.
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #257 (4913c0a) into master (37b35a4) will decrease coverage by 0.88%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
- Coverage   97.76%   96.88%   -0.89%     
==========================================
  Files          19       19              
  Lines        2779     2758      -21     
==========================================
- Hits         2717     2672      -45     
- Misses         62       86      +24     
Impacted Files Coverage Δ
lib/rufo/formatter.rb 96.62% <0.00%> (-1.22%) ⬇️
lib/rufo/command.rb 89.90% <0.00%> (-0.28%) ⬇️
spec/lib/rufo/command_spec.rb 97.52% <0.00%> (-0.10%) ⬇️
spec/lib/rufo/formatter_spec.rb 94.73% <0.00%> (-0.10%) ⬇️
lib/rufo/dot_file.rb 100.00% <0.00%> (ø)
lib/rufo/settings.rb 100.00% <0.00%> (ø)
lib/rufo/file_list.rb 100.00% <0.00%> (ø)
lib/rufo/file_finder.rb 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37b35a4...4913c0a. Read the comment docs.

@gingermusketeer
Copy link
Member

@tnir Thanks a lot for the PR :)

@gingermusketeer gingermusketeer merged commit b87e21e into ruby-formatter:master May 5, 2021
@tnir tnir deleted the ruby30 branch May 6, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants