Update travis CI adding latest Ruby and JRuby versions; fix failure on JRuby 9.2 #733
Conversation
.travis.yml
Outdated
| @@ -13,10 +13,13 @@ rvm: | |||
| - 2.0.0 | |||
| - 1.9.3 | |||
|
|
|||
| - jruby-9.2.0.0 | |||
There was a problem hiding this comment.
jruby-9.2.0.0 should be on line 6, could you move it there please.
| - jruby-9.0.5.0 | ||
| - jruby-1.7.27 | ||
|
|
||
| - ruby-head | ||
| - ruby-2.6.0-preview2 |
There was a problem hiding this comment.
please add it to allowed failure
|
Thanks for trying truffleruby. I have an #720 for it. You might want to leave it up to me, since I can more easily solve any issues there. I hope that it will be straight forward after I'll make sure it works for c-r. |
ivoanjo
force-pushed
the
update-travis-config
branch
from
c2245dc to
f36a8d4
Compare
|
@pitr-ch fixed, thanks for the feedback! |
|
@ivoanjo would you be interested to look into why is Travis failing for JRuby 9.2? |
pitr-ch
changed the title
|
@pitr-ch I already did! ;) It's caused by jruby/jruby#5229, which has already been fixed upstream in jruby/jruby#5231. I was not sure if it was worth adding it to |
|
@ianks cool and thanks! Since people will use JRuby 9.2 anyway could you fix it in concurrent-ruby so it does not fail for the users even though it's JRuby's bug. |
Due to a bug in JRuby 9.2.0.0, mutating the result of `Module#to_s` actually changes the result of other `Module#to_s` calls to the same module or class, rather than returning a new `String`. This broke `AbstractStruct#pr_underscore` which is used when rendering `#inspect` for structures. This was already fixed upstream, but as a workaround, let's dup the String before we mutate it, so as to not trip anyone using this JRuby version (and to restore Travis to beautiful green). Issue jruby/jruby#5229
ivoanjo
force-pushed
the
update-travis-config
branch
from
f36a8d4 to
cb4cded
Compare
|
I've added created the workaround and added it to this PR (rather than creating a separate one), so that we can merge with a clean travis. |
ghost
removed
the
Hello there, here's a small addition!
I also took a stab at adding truffleruby which is now available in rvm master but was not able to force an rvm upgrade before Travis attempts to install the target Ruby, so I guess we'll need to wait until the next rvm release.
Note: Tests seem to be broken with JRuby 9.2.0.0, I'll submit a separate issue for that.