Skip to content
This repository has been archived by the owner on Sep 11, 2022. It is now read-only.

URI Query Parameters #46

Merged
merged 2 commits into from
Jan 4, 2018
Merged

URI Query Parameters #46

merged 2 commits into from
Jan 4, 2018

Conversation

Tensho
Copy link
Contributor

@Tensho Tensho commented Dec 20, 2017 •
edited
Loading

@Tensho Tensho force-pushed the connection-uri-query-parameters branch from cc29f0a to f718d85 Compare December 21, 2017 17:14
@Tensho Tensho changed the title [WIP] URI Query Parameters URI Query Parameters Dec 21, 2017
@Tensho
Copy link
Contributor Author

Tensho commented Dec 22, 2017

@michaelklishin, It's ready, please check the description.

@Tensho
Copy link
Contributor Author

Tensho commented Dec 28, 2017

PING

michaelklishin
michaelklishin suggested changes Dec 28, 2017
View reviewed changes
Copy link
Member

@michaelklishin michaelklishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot approve a piece of docs that uses instance_variable_get. It's sufficient to say that the transport will be configured to use the provided CA certificate and client certificate/key pair.

@Tensho
Copy link
Contributor Author

Tensho commented Dec 29, 2017 •
edited
Loading

Fair enough, I've recently exposed public api for paths in Bunny::Transport, so referred to it in example.

@Tensho
Copy link
Contributor Author

Tensho commented Jan 3, 2018

PING

@Tensho
Copy link
Contributor Author

Tensho commented Jan 3, 2018

Is it possible to release new bunny version with query parameters parsing in January?

@michaelklishin michaelklishin merged commit 5cca887 into ruby-amqp:master Jan 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tensho @michaelklishin