Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping all gems to newest versions #45

Merged

Conversation

nielsjansendk
Copy link
Contributor

Bumping gems to the following versions:

rspec to version 3.9
bunny to version 2.15.0
hashie to version 4.1
multi_json to version 1.14.1
faraday to version 1.0.1
faraday-middleware to version 1.0

Copy link
Member

@michaelklishin michaelklishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please back out all change log updates.

@@ -288,7 +288,7 @@ it possible to access the URI a client instance uses.
### Meaningful Exceptions for 4xx and 5xx Responses

`4xx` and `5xx` responses now will result in meaningful exceptions
being raised. For example, `404` responses will raise `Faraday::Error::ResourceNotFound`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot retroactively edit a change log entry for 0.4.0

michaelklishin added a commit that referenced this pull request Apr 22, 2020
@michaelklishin michaelklishin merged commit 3de88c2 into ruby-amqp:master Apr 22, 2020
@michaelklishin
Copy link
Member

I undid the changelog change and added a new changelog entry with a mention of the exception class change. Thank you!

This was referenced Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants