Don't recover from network failures in Transport#read_fully #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recovering from network failures replaces the transport, so it is better to reply on the calling code to do the recovery.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #359
When recovering from a network failure,
read_fullyreturns the return value of the call to@session.handle_network_failure(e).bunny/lib/bunny/transport.rb
Line 221 in 641088f
In some cases this is a
Hashreturned from here:bunny/lib/bunny/session.rb
Line 705 in 641088f
It makes sense to avoid recovering from network failures inside
Transport#read_fullyas the recovery code replaces the transport itself. The reader loop can catch the failure and do the recovery for us.