[Fix #8131]: Ignore escapes of delimiters in Style/RedundantRegexpEscape #8138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Jun 11, 2020
Co-authored-by: Koichi ITO <[email protected]>
bbatsov
reviewed
Jun 12, 2020
| ALLOWED_WITHIN_CHAR_CLASS_METACHAR_ESCAPES.include?(char) | ||
| else | ||
| ALLOWED_OUTSIDE_CHAR_CLASS_METACHAR_ESCAPES.include?(char) | ||
| end | ||
| end | ||
|
|
||
| def delimiter?(node, char) |
There was a problem hiding this comment.
Looks like something for rubocop-ast. :-)
|
Thanks! |
marcandre
reviewed
Jun 12, 2020
| ALLOWED_WITHIN_CHAR_CLASS_METACHAR_ESCAPES.include?(char) | ||
| else | ||
| ALLOWED_OUTSIDE_CHAR_CLASS_METACHAR_ESCAPES.include?(char) | ||
| end | ||
| end | ||
|
|
||
| def delimiter?(node, char) | ||
| delimiters = [ | ||
| node.loc.begin.source.chars.last, |
There was a problem hiding this comment.
Looks like we're missing a performance cop against chars.first / last / slice / []... I created rubocop/rubocop-performance#139
There was a problem hiding this comment.
Also wondering if Range#[] as an optimized shortcut for Range#source[] is worth it (avoid intermediate string)
owst
added a commit
to owst/rubocop-ast
that referenced
this pull request
Jun 15, 2020
As suggested by @bbatsov here: rubocop/rubocop#8138 (comment)
bbatsov
pushed a commit
to rubocop/rubocop-ast
that referenced
this pull request
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must allow
%rdelimiters to be escaped, e.g.%r~\~~Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.