Upgrade rubocop to 0.36 #60
Conversation
| @@ -0,0 +1,3 @@ | |||
| [submodule "vendor/rubocop"] | |||
There was a problem hiding this comment.
Did you intend to commit this?
There was a problem hiding this comment.
Yes, and I meant to make a change to the README as well. Makes much more sense to just add rubocop as a submodule than to require the user to explicitly git clone the latest master and hope nothing breaks.
There was a problem hiding this comment.
I see. You might want to make that a separate PR since it's not directly related to the RuboCop upgrade.
There was a problem hiding this comment.
Fair point; I'll split it out.
|
👍 @jawshooah could you look into the 'codeclimate-test-reporter' error in the test? |
|
That error has been around ever since RuboCop switched from Coveralls to CodeClimate, nothing to do with the changes in this PR. |
|
Great! In that case ping @nevir 😄 |
|
My PR (#63) should fix the Travis issues with CodeClimate, but it requires both PR's by @jawshooah to be merged first. |
|
What is the status of this, when can we merge? |
|
/cc @geniou @bquorning |
|
Any news on this one? |
|
Waiting on @nevir, looks like. |
|
+1 |
|
Now there's Rubocop 0.37 https://github.com/bbatsov/rubocop/blob/master/CHANGELOG.md#0370-04022016 |
|
Yup, I will merge this today, and go through other tickets. Then update to 0.37.0. |
|
@nijikon Will you be pushing a new version to rubygems? |
|
@DexterTheDragon yes, working on it right now |
see rubocop/rubocop-rspec#60 Merged but no release yet.
Also fix offenses introduced by the upgrade.